Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-23.11] htb-toolkit: init at unstable-2024-01-17 #282203

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Bot-based backport to release-23.11, triggered by a label in #281650.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

Copy link
Contributor

@D3vil0p3r D3vil0p3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@D3vil0p3r
Copy link
Contributor

Hey @h7x4 usually the merge of backporting PR is automatic or it needs N manual approvals/reviewers?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1394

@h7x4
Copy link
Member

h7x4 commented Jan 21, 2024

@D3vil0p3r The backport PRs still needs a committer. But the intent of backport reviews is not so much about code quality (which should be fine since it was already merged into master), but more so about whether or not it is acceptable to backport (see the link the bot posted). Since this is a new package, I think it fits the criteria without problems.

@h7x4 h7x4 merged commit d639898 into release-23.11 Jan 21, 2024
24 checks passed
@h7x4 h7x4 deleted the backport-281650-to-release-23.11 branch January 21, 2024 23:07
@D3vil0p3r
Copy link
Contributor

@h7x4 sorry, one question. After a backport PR is merged, how much time is needed before the package is published in 23.11? Is there some link to track it?

@h7x4
Copy link
Member

h7x4 commented Jan 23, 2024

There is indeed - https://nixpk.gs/pr-tracker.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants