Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

liba2i: init at 0.6 #282329

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

liba2i: init at 0.6 #282329

wants to merge 2 commits into from

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Jan 20, 2024

Project: https://www.alejandro-colomar.es/src/alx/alx/lib/liba2i.git/

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@drupol drupol force-pushed the init/liba2i branch 2 times, most recently from bfeacc2 to 2e95d1d Compare January 20, 2024 16:42
@drupol drupol force-pushed the init/liba2i branch 2 times, most recently from 9613253 to 0822bcb Compare January 20, 2024 17:28
@2xsaiko
Copy link
Contributor

2xsaiko commented Jan 20, 2024

I can't figure out how to push to your branch so here's the commits: drupol/nixpkgs@init/liba2i...2xsaiko:nixpkgs:init/liba2i

@AndersonTorres
Copy link
Member

I can't figure out how to push to your branch so here's the commits: drupol/nixpkgs@init/liba2i...2xsaiko:nixpkgs:init/liba2i

Use suggestions.

@drupol
Copy link
Contributor Author

drupol commented Jan 20, 2024

I can't figure out how to push to your branch so here's the commits: drupol/nixpkgs@init/liba2i...2xsaiko:nixpkgs:init/liba2i

Use suggestions.

It's totally fine for me, I'll merge those changes as soon as I'm back at my laptop.

@drupol drupol force-pushed the init/liba2i branch 2 times, most recently from c30fada to bb07cdb Compare January 20, 2024 22:03
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@drupol drupol changed the title liba2i: init at unstable-2024-01-13 liba2i: init at unstable-2024-01-20 Jan 22, 2024
@drupol drupol changed the title liba2i: init at unstable-2024-01-20 liba2i: init at unstable-2024-01-28 Jan 31, 2024
@drupol drupol changed the title liba2i: init at unstable-2024-01-28 liba2i: init at 0.6 Feb 14, 2024
Copy link
Contributor

@2xsaiko 2xsaiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output has a link lib/liba2i.so -> liba2i.so.0 but the library is at lib/liba2i.so.0.6 so the link is broken.

pkgs/by-name/li/liba2i/package.nix Outdated Show resolved Hide resolved
Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants