-
-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
liba2i: init at 0.6 #282329
base: master
Are you sure you want to change the base?
liba2i: init at 0.6 #282329
Conversation
bfeacc2
to
2e95d1d
Compare
9613253
to
0822bcb
Compare
I can't figure out how to push to your branch so here's the commits: drupol/nixpkgs@init/liba2i...2xsaiko:nixpkgs:init/liba2i |
Use suggestions. |
It's totally fine for me, I'll merge those changes as soon as I'm back at my laptop. |
c30fada
to
bb07cdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output has a link lib/liba2i.so -> liba2i.so.0 but the library is at lib/liba2i.so.0.6 so the link is broken.
Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
Project: https://www.alejandro-colomar.es/src/alx/alx/lib/liba2i.git/
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.