Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c-periphery: init at 2.4.2 #282375

Merged
merged 1 commit into from
Jan 28, 2024
Merged

c-periphery: init at 2.4.2 #282375

merged 1 commit into from
Jan 28, 2024

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Jan 20, 2024

Description of changes

c-periphery - C Library for Linux Peripheral I/O (GPIO, LED, PWM, SPI, I2C, MMIO, Serial)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux (cross)
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/c-/c-periphery/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/c-/c-periphery/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/c-/c-periphery/package.nix Outdated Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3320


postPatch = ''
substituteInPlace src/libperiphery.pc.in \
--replace '=''${prefix}/' '=' \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to upstream this

@sikmir
Copy link
Member Author

sikmir commented Jan 27, 2024

Result of nixpkgs-review pr 282375 run on x86_64-linux 1

2 packages built:
  • c-periphery
  • c-periphery.lib

Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
    "blacklisted": [],
    "broken": [],
    "built": [
        "c-periphery",
        "c-periphery.lib"
    ],
    "extra-nixpkgs-config": null,
    "failed": [],
    "non-existent": [],
    "pr": 282375,
    "system": "x86_64-linux",
    "tests": []
}

Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated approval :)

{
    "blacklisted": [],
    "broken": [],
    "built": [
        "c-periphery",
        "c-periphery.dev",
        "c-periphery.lib"
    ],
    "extra-nixpkgs-config": null,
    "failed": [],
    "non-existent": [],
    "pr": 282375,
    "system": "x86_64-linux",
    "tests": []
}

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1419

@SuperSandro2000 SuperSandro2000 merged commit 1bd6b2b into NixOS:master Jan 28, 2024
24 checks passed
@sikmir sikmir deleted the c-periphery branch January 28, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants