Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

narsil: init at 1.3.0-49-gc042b573a #282484

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Conversation

Nanotwerp
Copy link
Contributor

Description of changes

Initializes NarSil, a roguelike that is a rewrite of Sil on top of modern Angband's codebase.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3310

pkgs/by-name/na/narsil/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/na/narsil/package.nix Outdated Show resolved Hide resolved
@Nanotwerp Nanotwerp force-pushed the narsil-init branch 2 times, most recently from 00a079f to 3f59247 Compare January 23, 2024 21:03
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1402

This package is being initialized at a specific rev due to the older 1.3.0 release executable being named "angband" instead of "narsil" in $out/bin/.

narsil: replace sha256 with hash

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>

narsil: add more verbose description

narsil: make description even more verbose

narsil: add a longDescription

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000 SuperSandro2000 merged commit 53741d3 into NixOS:master Jan 30, 2024
24 checks passed
@Nanotwerp Nanotwerp deleted the narsil-init branch February 11, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants