Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtt: init at 8 #282706

Merged
merged 1 commit into from
Jan 23, 2024
Merged

gtt: init at 8 #282706

merged 1 commit into from
Jan 23, 2024

Conversation

linuxissuper
Copy link
Contributor

@linuxissuper linuxissuper commented Jan 21, 2024

Description of changes

add gtt: Google Translate TUI (Originally). Now support Apertium, Argos, Bing, ChatGPT, DeepL, Google, Reverso.
from https://github.com/eeeXun/gtt

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@kirillrdy
Copy link
Member

@linuxissuper can you also update PR title

@linuxissuper linuxissuper changed the title Add package/gtt Add package gtt Jan 22, 2024
@kirillrdy
Copy link
Member

@linuxissuper sorry I wasn't clear enough, PR title should be gtt: init at 8

@linuxissuper linuxissuper changed the title Add package gtt gtt: init at 8 Jan 22, 2024
@linuxissuper
Copy link
Contributor Author

@linuxissuper sorry I wasn't clear enough, PR title should be gtt: init at 8

I'm sorry, should've been obvious to me 馃檲
not sure why the title wasn't the first commit anyway 馃

Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kirillrdy kirillrdy merged commit 69edbe1 into NixOS:master Jan 23, 2024
27 checks passed
@linuxissuper linuxissuper deleted the add-package/gtt branch January 24, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants