Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyprland-monitor-attached: init at 0.1.5 #283262

Merged
merged 1 commit into from Apr 9, 2024

Conversation

bddvlpr
Copy link
Member

@bddvlpr bddvlpr commented Jan 23, 2024

Description of changes

Requested at #282397, tested and working. Doesn't have actual tagging / version releases, based on last commit at 2023-10-03.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@bddvlpr
Copy link
Member Author

bddvlpr commented Jan 23, 2024

Result of nixpkgs-review pr 283262 run on x86_64-linux 1

1 package built:
  • hyprland-monitor-attached

Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update the version in the commit message

pkgs/by-name/hy/hyprland-monitor-attached/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/hy/hyprland-monitor-attached/package.nix Outdated Show resolved Hide resolved
@bddvlpr bddvlpr force-pushed the hyprland-monitor-attached/init branch from 22bf276 to 49922ef Compare March 15, 2024 11:32
@bddvlpr bddvlpr changed the title hyprland-monitor-attached: init at unstable-2023-10-03 hyprland-monitor-attached: init at 0.1.5 Mar 15, 2024
@donovanglover
Copy link
Member

Result of nixpkgs-review pr 283262 run on x86_64-linux 1

1 package built:
  • hyprland-monitor-attached

Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aleksanaa Aleksanaa merged commit ddf067c into NixOS:master Apr 9, 2024
26 checks passed
@bddvlpr bddvlpr deleted the hyprland-monitor-attached/init branch April 9, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants