stirling-pdf: init at 0.22.3 #283305
Merged
stirling-pdf: init at 0.22.3 #283305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested it and it works. I don't know if I care. I'm just happy to try it out! Thank you so much for packaging it! |
TomaSajt
force-pushed
the
stirling-pdf
branch
2 times, most recently
from
438be55
to
f0b0f37
Compare
TomaSajt
force-pushed
the
stirling-pdf
branch
2 times, most recently
from
cfed41f
to
bded1c9
Compare
|
Result of 1 package built:
|
| | perl -pe 's#(.*/([^/]+)/([^/]+)/([^/]+)/[0-9a-f]{30,40}/([^/\s]+))$# ($x = $2) =~ tr|\.|/|; "install -Dm444 $1 \$out/$x/$3/$4/$5" #e' \ | ||
| | sh | ||
| # weird dependency resolution fix | ||
| ln -s $out/com/squareup/okio/okio-jvm/3.6.0/okio-jvm-3.6.0.jar $out/com/squareup/okio/okio/3.6.0/okio-3.6.0.jar |
There was a problem hiding this comment.
How maintainable is this bit hardcoding versions here in case upstream dependencies change?
There was a problem hiding this comment.
It's going to return an error if the dependencies change, so I can easily just change this version accordingly.
Tom-Hubrecht
reviewed
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #282169
This PR adds 1 package:
stirling-pdfThis is a gradle app, so it got the typical gradle treatment: prefetch deps, then use them as a fake maven repository
The package generates a signed jar file, which is apparently not supported by the backend of
stripJavaArchivesHook, so I had to use the built-in gradle way of fixing the timestamps of the jar files.Other than this patch there's one which removes the
spotless, because it couldn't resolve all its dependencies correctly. There's another one, which removes the timestamp header from a.propertiesfileThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.