Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.msgraph-core: 0.2.2 -> 1.0.0 #283337

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Jan 23, 2024

breaks parsedmarc because of domainaware/parsedmarc#464

Description of changes

Diff: microsoftgraph/msgraph-sdk-python-core@v0.2.2...v1.0.0

Changelog: https://github.com/microsoftgraph/msgraph-sdk-python-core/blob/v1.0.0/CHANGELOG.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @peterablehmann


Add a 馃憤 reaction to pull requests you find important.

@dotlambda dotlambda marked this pull request as draft January 23, 2024 23:23
@dotlambda
Copy link
Member Author

Result of nixpkgs-review pr 283337 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python311Packages.parsedmarc
  • python311Packages.parsedmarc.dist
  • python312Packages.microsoft-kiota-abstractions
  • python312Packages.microsoft-kiota-abstractions.dist
2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
12 packages built:
  • python311Packages.microsoft-kiota-abstractions
  • python311Packages.microsoft-kiota-abstractions.dist
  • python311Packages.microsoft-kiota-authentication-azure
  • python311Packages.microsoft-kiota-authentication-azure.dist
  • python311Packages.microsoft-kiota-http
  • python311Packages.microsoft-kiota-http.dist
  • python311Packages.msgraph-core
  • python311Packages.msgraph-core.dist
  • python311Packages.std-uritemplate
  • python311Packages.std-uritemplate.dist
  • python312Packages.std-uritemplate
  • python312Packages.std-uritemplate.dist

@dotlambda
Copy link
Member Author

Result of nixpkgs-review pr 283337 run on x86_64-linux

Note that the top-level parsedmarc isn't even rebuilt by this PR.

Copy link
Member

@e1mo e1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding parsedmarc: The fix looks good. I'd prefer parsedmarc being built by nixpkgs-review to catch future regressions, but with upstream being aware, this should hopefully only be a temporary situation.

@dotlambda
Copy link
Member Author

I'd prefer parsedmarc being built by nixpkgs-review to catch future regressions

Parsedmarc will be built if it is changed at all. This PR doesn't change the derivation pkgs.parsedmarc is instantiated into.

@wegank
Copy link
Member

wegank commented Mar 21, 2024

Done in ed5871d?

@wegank wegank marked this pull request as draft March 21, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants