Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update bazecor from 1.3.9 to 1.3.10 #283766

Closed
wants to merge 1 commit into from
Closed

Conversation

gabyx
Copy link
Contributor

@gabyx gabyx commented Jan 25, 2024

Description of changes

  • Update bazecor to 1.3.10

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@gabyx gabyx changed the title feat: Update bazecor to 1.3.10 feat: Update bazecor from 1.3.9 to 1.3.10 Jan 25, 2024
@ofborg ofborg bot requested a review from amesgen January 25, 2024 13:51
Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, only the commit message should be changed to conform to the commit conventions:

basecor: 1.3.9 -> 1.3.10

@gabyx
Copy link
Contributor Author

gabyx commented Feb 6, 2024

Arent Nixpkgs doing squash merges? So the whole commit convention thing would be moved on the the shoulders of the maintainers. (dont get me wrong I like that)...

@amesgen
Copy link
Member

amesgen commented Feb 6, 2024

Thanks! BTW: bazecor 1.3.11 has been released in the meantime: https://github.com/Dygmalab/Bazecor/releases/tag/v1.3.11

@gabyx
Copy link
Contributor Author

gabyx commented Feb 15, 2024

Sure I bumbed it again.

@gabyx
Copy link
Contributor Author

gabyx commented Mar 9, 2024

@amesgen Can this be merged? Thanks. ;-)

Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be merged? Thanks. ;-)

I am not a nixpkgs committer, so I can't merge this, but you can post this e.g. here: https://discourse.nixos.org/t/prs-already-reviewed/2617/955

pkgs/applications/misc/bazecor/default.nix Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1522

@ofborg ofborg bot requested a review from amesgen March 12, 2024 16:04
@gabyx
Copy link
Contributor Author

gabyx commented Mar 27, 2024

@amesgen: should be good now.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1578

@amesgen amesgen mentioned this pull request Apr 17, 2024
13 tasks
@NickCao
Copy link
Member

NickCao commented Apr 18, 2024

Superseded by #304887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants