-
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update bazecor
from 1.3.9 to 1.3.10
#283766
Conversation
bazecor
to 1.3.10bazecor
from 1.3.9 to 1.3.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good, only the commit message should be changed to conform to the commit conventions:
basecor: 1.3.9 -> 1.3.10
Arent Nixpkgs doing squash merges? So the whole commit convention thing would be moved on the the shoulders of the maintainers. (dont get me wrong I like that)... |
Thanks! BTW: bazecor 1.3.11 has been released in the meantime: https://github.com/Dygmalab/Bazecor/releases/tag/v1.3.11 |
Sure I bumbed it again. |
@amesgen Can this be merged? Thanks. ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be merged? Thanks. ;-)
I am not a nixpkgs committer, so I can't merge this, but you can post this e.g. here: https://discourse.nixos.org/t/prs-already-reviewed/2617/955
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1522 |
@amesgen: should be good now. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1578 |
Superseded by #304887 |
Description of changes
bazecor
to 1.3.10Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.