linux_rpi3: fix build failure due to wrong Kconfig #284035
Conversation
ofborg
bot
requested review from
alyssais,
NeQuissimus,
Ma27,
thoughtpolice and
TredwellGit
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 2 packages failed to build and are new build failures:2 packages built:
|
|
The initial error is gone, but I'm now getting: |
Because of NixOS's generate-config.pl tries to answer 'M' to as much configs as possible, this exposes the wrong Kconfig in the RPi-specific code which is added in the new kernel tree intended to support RPi 5. Add kernel patches to fix the Kconfig, which results in the relavant part being disabled on the RPi 3 build of the kernel.
peat-psuwit
force-pushed
the
for-upstream/fix-linux-rpi3
branch
from
a3d1f04
to
bb51848
Compare
|
The new error should also be addressed. Please take another look. |
|
Awesome, will do 馃憤 |
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 4 packages built:
|
|
@peat-psuwit both packages build. Thanks for your work, LGTM! |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3454 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1466 |
|
@ofborg build linuxKernel.kernels.linux_rpi3 linuxKernel.kernels.linux_rpi4 |
Description of changes
Because of NixOS's generate-config.pl tries to answer 'M' to as much configs as possible, this exposes the wrong Kconfig in the RPi-specific code which is added in the new kernel tree intended to support RPi 5.
Add a kernel patch to fix the Kconfig, which results in the relavant part being disabled on the RPi 3 build of the kernel.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.