-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
init MultiQC at 1.19 #284361
base: master
Are you sure you want to change the base?
init MultiQC at 1.19 #284361
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One reason that no body reviews this could be the fact you marked it as a draft.
@@ -42054,4 +42054,6 @@ with pkgs; | |||
insulator2 = callPackage ../applications/misc/insulator2 {}; | |||
|
|||
animdl = python3Packages.callPackage ../applications/video/animdl { }; | |||
|
|||
multiqc = callPackage ../applications/science/biology/multiqc { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use pkgs/by-name
and avoid editing the way too large all-packages.nix
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nowadays by-name is mandatory
Description of changes
Inits MultiQC and missing python packages
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.