Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vorta: 0.8.12 -> 0.9.1 #284601

Merged
merged 1 commit into from
Mar 6, 2024
Merged

vorta: 0.8.12 -> 0.9.1 #284601

merged 1 commit into from
Mar 6, 2024

Conversation

dotlambda
Copy link
Member

Description of changes

Diff: borgbase/vorta@v0.8.12...v0.9.1

Changelog: https://github.com/borgbase/vorta/releases/tag/v0.9.1

fixes #284532

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @nadir-ishiguro


Add a 👍 reaction to pull requests you find important.

"test_ssh_dialog"
"test_create"
"test_scheduler_create_backup"
# QObject::connect: No such signal QPlatformNativeInterface::systemTrayWindowChanged(QScreen*)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any ideas how to fix this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it requires a real screen? Did you try xvfb-run?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xvfb-run doesn't seem to help

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combining it with dbus-run-session also doesn't fix the error.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3385

@dotlambda dotlambda marked this pull request as ready for review February 6, 2024 18:29
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3586

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1506

@dotlambda
Copy link
Member Author

I'll merge this and hope that someone figures out the tests eventually.

@dotlambda dotlambda merged commit 6faf6af into NixOS:master Mar 6, 2024
26 checks passed
@dotlambda dotlambda deleted the vorta-0.9.1 branch March 6, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: vorta 0.8.12 → 0.9.1
4 participants