Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

tokyo-night-gtk: change package name #284621

Merged
merged 2 commits into from Feb 17, 2024
Merged

Conversation

D3vil0p3r
Copy link
Contributor

Description of changes

Change name to tokyonight-gtk-theme in order to be consistent with the other theme packages of the same theme author in Nixpkgs and other Linux repositories (like Arch Linux).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@D3vil0p3r D3vil0p3r force-pushed the patch-6 branch 2 times, most recently from e99f4fc to 27fc605 Compare January 28, 2024 22:12
@D3vil0p3r D3vil0p3r changed the title tokyo-night-gtk: change package name tokyo-night-gtk: move to by-name and change package name Jan 28, 2024
@D3vil0p3r D3vil0p3r added the backport release-23.11 Backport PR automatically label Jan 28, 2024
@D3vil0p3r D3vil0p3r force-pushed the patch-6 branch 4 times, most recently from 5fb24a6 to d3a5499 Compare January 28, 2024 22:31
@eclairevoyant eclairevoyant removed the backport release-23.11 Backport PR automatically label Jan 28, 2024
@D3vil0p3r D3vil0p3r force-pushed the patch-6 branch 2 times, most recently from 7e12898 to b194f01 Compare January 28, 2024 22:52
@D3vil0p3r D3vil0p3r marked this pull request as ready for review January 28, 2024 22:56
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3352

@D3vil0p3r D3vil0p3r changed the title tokyo-night-gtk: move to by-name and change package name tokyo-night-gtk: change package name Jan 28, 2024
@D3vil0p3r D3vil0p3r requested a review from h7x4 January 30, 2024 12:51
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to aliases.nix

@D3vil0p3r
Copy link
Contributor Author

Please add an entry to aliases.nix

@SuperSandro2000 should I add the following in that file?

tokyo-night-gtk = tokyonight-gtk-theme; # Added 2024-01-28

@SuperSandro2000
Copy link
Member

Sounds about right.

@D3vil0p3r
Copy link
Contributor Author

Sounds about right.

@SuperSandro2000 fixed.

@SuperSandro2000 SuperSandro2000 merged commit 5b83373 into NixOS:master Feb 17, 2024
19 checks passed
@D3vil0p3r D3vil0p3r deleted the patch-6 branch February 17, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants