New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
tokyo-night-gtk: change package name #284621
Conversation
e99f4fc
to
27fc605
Compare
5fb24a6
to
d3a5499
Compare
7e12898
to
b194f01
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3352 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an entry to aliases.nix
@SuperSandro2000 should I add the following in that file?
|
Sounds about right. |
@SuperSandro2000 fixed. |
489630d
to
1234093
Compare
Description of changes
Change name to
tokyonight-gtk-theme
in order to be consistent with the other theme packages of the same theme author in Nixpkgs and other Linux repositories (like Arch Linux).Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.