Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests.nixpkgs-check-by-name: Syntactic callPackage detection and allow new package variants #285089

Merged
merged 7 commits into from
Feb 5, 2024

Commits on Jan 30, 2024

  1. tests.nixpkgs-check-by-name: LineIndex functionality, semantics, tests

    - `fromlinecolumn` is added to be almost the reverse of `line`.
      This is needed in the future to get from `builtins.unsafeGetAttrPos`
      locations to the index for rnix
    - Previously the semantics for newline indices were not really defined,
      now they are, and make more sense.
    - Now there's a unit test for these functions
    infinisil committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    ed89291 View commit details
    Browse the repository at this point in the history
  2. tests.nixpkgs-check-by-name: Syntactic callPackage detection

    This makes the callPackage detection stronger by syntactically detecting
    whether an attribute is using callPackage
    
    See the added test case for why this is needed.
    infinisil committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    0bcb052 View commit details
    Browse the repository at this point in the history
  3. tests.nixpkgs-check-by-name: Re-use nixFileCache more

    Makes the reference check use the nixFileCache instead of separately
    parsing and resolving paths
    infinisil committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    db435ae View commit details
    Browse the repository at this point in the history
  4. tests.nixpkgs-check-by-name: Format

    With `cargo fmt`
    
    Explicitly didn't do that for previous commits in order to keep the diff
    more easily reviewable
    infinisil committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    46da6c5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7d1f0a4 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Configuration menu
    Copy the full SHA
    37a54e3 View commit details
    Browse the repository at this point in the history
  2. tests.nixpkgs-check-by-name: Refactor eval.rs

    There was too much indentation!
    infinisil committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    474e7e7 View commit details
    Browse the repository at this point in the history