nodePackages.bash-language-server: Add shellcheck to bin path

[kjhoerr]

Description of changes

Adds shellcheck to the PATH of bash-language-server. It is not a build dependency but without it, bash-language-server does not do any linting or code analysis.

https://github.com/bash-lsp/bash-language-server?tab=readme-ov-file#dependencies

I have tested the LSP directly using Helix in my home-manager configuration and it works great.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3365

[SuperSandro2000]

Please refactor the package to use buildNpmPackage and fix this issue there #229475

[dotlambda]

Please refactor the package to use buildNpmPackage and fix this issue there #229475

Bash-language-server uses pnpm which we don't currently have tooling for (#231513). Thus it's impossible to build bash-language-server from source unless we vendor a package-lock.json.

[dotlambda]

Please refactor the package to use buildNpmPackage and fix this issue there #229475

Bash-language-server uses pnpm which we don't currently have tooling for (#231513). Thus it's impossible to build bash-language-server from source unless we vendor a package-lock.json.

Here's my try: master...dotlambda:bash-language-server-buildNpmPackage
It doesn't build yet because there are two separate package.json and lock files in the repo and we'd have to run npm install for both of them.