gdal: Wrap executables in environment containing numpy #285391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirm, I can reproduce the problem. |
|
I am wondering how gdal2tiles tests are passing if we are missing some dependency. |
|
We are adding packages on Content of that |
imincik
reviewed
Feb 1, 2024
imincik
reviewed
Feb 1, 2024
|
Would you please avoid starting change description with capital letter ( change Thank you very much for your contribution. |
mpickering
force-pushed
the
wip/gdal-numpy-wrap
branch
from
12506e6
to
276a1fd
Compare
|
@imincik I have updated with your suggested changes, but for the record I find this style of nitpicking review very annoying and I think maintainers should be more lenient when accepting patches from casual contributors. |
I very much appreciate your contribution. I am not happy with nitpicking either and I think this was the most I ever made. Sorry again. I hope we can have some automatic linter doing it for use automatically. |
|
Result of 9 packages marked as broken and skipped:
3 packages failed to build:
77 packages built:
|
imincik
approved these changes
Feb 1, 2024
Since gdal 3.8.1 there is a numpy dependency on the python library it seems. This resulted in broken python scrips such as gdal2tiles.py ``` [nix-shell:~/map-scraper/shake-rg]$ gdal2tiles.py --help ModuleNotFoundError: No module named 'numpy' ``` Therefore it's important to wrap the executables in an environment which contains numpy.
imincik
force-pushed
the
wip/gdal-numpy-wrap
branch
from
276a1fd
to
76fd69c
Compare
imincik
added a commit
to imincik/geospatial-nix
that referenced
this pull request
Feb 16, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/week-in-geospatial-team/37035/8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since gdal 3.8.1 there is a numpy dependency on the python library it seems. This resulted in broken python scrips such as gdal2tiles.py
Therefore it's important to wrap the executables in an environment which contains numpy.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.