lib.modules.doRename: Add condition parameter #285612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberth
added
0.kind: enhancement
6.topic: module system
This is to support single-to-multi service migrations, so that the `to` (e.g. `foos.""`) isn't defined unconditionally. See test cases.
roberth
force-pushed
the
doRename-condition
branch
from
65b60c5
to
29c7665
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
infinisil
approved these changes
Feb 5, 2024
| @@ -1256,7 +1256,7 @@ let | |||
| (opt.highestPrio or defaultOverridePriority) | |||
| (f opt.value); | |||
|
|
|||
| doRename = { from, to, visible, warn, use, withPriority ? true }: | |||
| doRename = { from, to, visible, warn, use, withPriority ? true, condition ? true }: | |||
There was a problem hiding this comment.
We don't have any docs for this function, but at least an inline comment here would be good
There was a problem hiding this comment.
Thanks! Here's the follow-up:
roberth
added a commit
to hercules-ci/nixpkgs
that referenced
this pull request
Feb 5, 2024
I don't think these are rendered yet, but this at least provides the content. Follow-up to NixOS#285612
roberth
added a commit
to hercules-ci/nixpkgs
that referenced
this pull request
Feb 5, 2024
I don't think these are rendered yet, but this at least provides the content. Follow-up to NixOS#285612
13 tasks
|
Successfully created backport PR for |
1 task
roberth
added a commit
to hercules-ci/nixpkgs
that referenced
this pull request
Feb 14, 2024
I don't think these are rendered yet, but this at least provides the content. Follow-up to NixOS#285612
github-actions bot
pushed a commit
to nix-community/nixpkgs.lib
that referenced
this pull request
Feb 25, 2024
I don't think these are rendered yet, but this at least provides the content. Follow-up to NixOS/nixpkgs#285612
sarahec
pushed a commit
to sarahec/nixpkgs
that referenced
this pull request
Feb 25, 2024
I don't think these are rendered yet, but this at least provides the content. Follow-up to NixOS#285612
github-actions bot
pushed a commit
to arcnmx/nixpkgs-lib
that referenced
this pull request
Mar 10, 2024
I don't think these are rendered yet, but this at least provides the content. Follow-up to NixOS/nixpkgs#285612
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is to support single-to-multi service migrations, so that the
to(e.g.foos."") isn't defined unconditionally. See test cases.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.