nxengine-evo: 2.6.4 -> 2.6.5-1 #286570
Merged
nxengine-evo: 2.6.4 -> 2.6.5-1 #286570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3434 |
|
Result of 1 package built:
|
jtbx
approved these changes
Feb 13, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1515 |
AndersonTorres
force-pushed
the
nxengine-evo
branch
from
76e85dd
to
971f816
Compare
|
@ofborg build nxengine-evo.override{includeAssets = true;} |
jtbx
reviewed
Mar 13, 2024
jtbx
approved these changes
Mar 22, 2024
|
Drafting because I am testing some magic. |
AndersonTorres
force-pushed
the
nxengine-evo
branch
from
b392a05
to
1435019
Compare
|
Now it's ready! |
AndersonTorres
force-pushed
the
nxengine-evo
branch
from
1435019
to
5c2cfac
Compare
- finalAttrs design pattern - extra patch to make it compile on modern CC - strictDeps - internalize assets - mainProgram
AndersonTorres
force-pushed
the
nxengine-evo
branch
from
5c2cfac
to
9fd0c38
Compare
Splitting the assets from the master expression.
AndersonTorres
force-pushed
the
nxengine-evo
branch
from
9fd0c38
to
975963c
Compare
|
Result of 1 package built:
|
superherointj
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.