Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mstflint: fix compilation with gcc 13 #286724

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

thillux
Copy link
Contributor

@thillux thillux commented Feb 6, 2024

GCC 13 complained really hard about missing definitions for uintXX_t. A one liner in mlxdpa elfio fixed this for me.

Tracked upstream: Mellanox/mstflint#916

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

GCC 13 complained really hard about missing definitions for uintXX_t.
A one liner in mlxdpa elfio fixed this for me.

Tracked upstream: Mellanox/mstflint#916

Signed-off-by: Markus Theil <theil.markus@gmail.com>
@thillux thillux marked this pull request as ready for review February 6, 2024 12:27
@WilliButz
Copy link
Member

@ofborg build mstflint

Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@WilliButz WilliButz merged commit 340870f into NixOS:master Feb 6, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants