netease-cloud-music-gtk: 2.2.0 -> 2.3.0 #287212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have a NetEase Cloud account, though... |
Aleksanaa
force-pushed
the
netease-cloud-music-gtk
branch
from
00789e1
to
de5d020
Compare
|
This is also affected by #271960, and I've added a workaround. |
|
Result of |
wegank
reviewed
Feb 8, 2024
Aleksanaa
force-pushed
the
netease-cloud-music-gtk
branch
from
309d330
to
5927978
Compare
|
The by-name check failure is irrelevant. |
wegank
force-pushed
the
netease-cloud-music-gtk
branch
from
5927978
to
613a70e
Compare
|
Result of 1 package built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
ping @wegank for testing (thanks in advance!The inability to play music may be due to the NetEase Cloud account being risk controlled, or it may be caused by a proxy. We need to find more people to test it.Tested and works. Current version in Nixpkgs doesn't work because of #271960. If you still find it unable to play music, try deleting
~/.cache/gstreamer-1.0.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.