rose-pine-cursor: init at 1.1.0 #287612
Merged
rose-pine-cursor: init at 1.1.0 #287612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aikooo7
force-pushed
the
add-rose-pine-cursor
branch
from
3fa45c6
to
d2221cb
Compare
jtbx
suggested changes
Feb 10, 2024
aikooo7
force-pushed
the
add-rose-pine-cursor
branch
from
2b0a2e3
to
92a193b
Compare
jtbx
reviewed
Feb 10, 2024
jtbx
reviewed
Feb 10, 2024
aikooo7
force-pushed
the
add-rose-pine-cursor
branch
2 times, most recently
from
6f839f2
to
eb777f2
Compare
|
I by mistake did a force push deleting the commit that added the runhook, so I just redid it and moved it where it was |
jtbx
suggested changes
Feb 10, 2024
fix: meta Co-authored-by: Jeremy <jtbx@duck.com> fix: replace stdenv with stdenvNoCC Co-authored-by: Jeremy <jtbx@duck.com> style: fix indentation Co-authored-by: Jeremy <jtbx@duck.com> fix: replace r flag with R Co-authored-by: Jeremy <jtbx@duck.com> fix: variables fix: add closing parentheses at the end of the file feat: skip configure phase feat: skip build phase feat: add runhook for preInstall and postInstall in installPhase Co-authored-by: Jeremy <jtbx@duck.com> Revert "feat: skip configure phase" This reverts commit db36e57. Revert "feat: skip build phase" This reverts commit 92a193b.
aikooo7
force-pushed
the
add-rose-pine-cursor
branch
from
eb777f2
to
d444fff
Compare
RoseHobgoblin
approved these changes
Mar 6, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1509 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Closes #287123
Add a 馃憤 reaction to pull requests you find important.