Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/mihomo: init #287966

Merged
merged 3 commits into from Mar 21, 2024
Merged

nixos/mihomo: init #287966

merged 3 commits into from Mar 21, 2024

Conversation

Guanran928
Copy link
Contributor

Description of changes

Adds a module for clash-meta, a rule-based proxy based on Go, similar to #250301.

I'm new to Nix/NixOS and nixpkgs, please tell if I did anything wrong. ^^

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work!

nixos/modules/services/networking/clash-meta.nix Outdated Show resolved Hide resolved
@Guanran928 Guanran928 force-pushed the clash-meta branch 2 times, most recently from 232f48c to 8868402 Compare March 1, 2024 17:38
@Guanran928
Copy link
Contributor Author

  • removed a few unnecessary comments.
  • using lib.concatStringsSep instead of builtins.concatStringsSep .
  • rebased to master to fix merge conflict.

@Guanran928
Copy link
Contributor Author

@Guanran928 Guanran928 changed the title nixos/clash-meta: init nixos/mihomo: init Mar 11, 2024
Copy link
Member

@oluceps oluceps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3660

@doronbehar
Copy link
Contributor

@ofborg test mihomo

@doronbehar doronbehar merged commit 2897be3 into NixOS:master Mar 21, 2024
26 of 27 checks passed
@Guanran928 Guanran928 mentioned this pull request Mar 21, 2024
13 tasks
@ThinkChaos
Copy link
Contributor

Hi, I got here from the release-notes because I didn't find anything that looks like a "rule-based proxy in Go" at the linked repo: MetaCubeX/mihomo.
The repo description is "A simple Python Pydantic model for Honkai: Star Rail parsed data from the Mihomo API."

I don't understand Chinese so maybe one of the other links in the PR clarifies this, but are the release notes correct?
Can they be improved because the current situation is confusing.

@oluceps
Copy link
Member

oluceps commented Apr 7, 2024

Hi, I got here from the release-notes because I didn't find anything that looks like a "rule-based proxy in Go" at the linked repo: MetaCubeX/mihomo. The repo description is "A simple Python Pydantic model for Honkai: Star Rail parsed data from the Mihomo API."

I don't understand Chinese so maybe one of the other links in the PR clarifies this, but are the release notes correct? Can they be improved because the current situation is confusing.

About the naming and description issue please refer to #271658 (comment)

@ThinkChaos
Copy link
Contributor

Ok I found the actual project, it's in a non default branch. I think that that branch should be linked from the release notes instead of default branch which shows a project seemingly unrelated to the actual service exposed by the module.
Again maybe some info is lost in translation for me, but I suspect most people that read the release notes and check out the project will have the same confusion as I did.

@doronbehar
Copy link
Contributor

doronbehar commented Apr 7, 2024 via email

@Guanran928
Copy link
Contributor Author

Feel free to write a PR changing URLs or other links and ping me for a review.

#302352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants