Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add geospatial team to maintainers for geospatial packages where I'm a maintainer #288107

Merged
merged 6 commits into from Feb 22, 2024

Conversation

das-g
Copy link
Member

@das-g das-g commented Feb 11, 2024

Description of changes

  • add geospatial team to meta.maintainers for geospatial packages (and dependencies of geospatial packages) where I (@das-g) am a maintainer

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@das-g das-g changed the title add geospatial team to maintainers for geospatial packages where I'm a maintainer remove myself from geospatial team & add geospatial team to maintainers for geospatial packages where I'm a maintainer Feb 11, 2024
@das-g das-g changed the title remove myself from geospatial team & add geospatial team to maintainers for geospatial packages where I'm a maintainer draft: add geospatial team to maintainers for geospatial packages where I'm a maintainer Feb 11, 2024
@das-g
Copy link
Member Author

das-g commented Feb 11, 2024

This shouldn't be merged before #288118 is merged, as otherwise I'd appear twice in the expanded lists of maintainers of these packages.

Appending "draft: " to the title didn't mark this PR as a draft (I guess that works only on GitLab, not GitHub?), thus temporarily closing this PR here, until #288118 is merged.

@das-g das-g closed this Feb 11, 2024
@dotlambda dotlambda reopened this Feb 11, 2024
@dotlambda dotlambda marked this pull request as draft February 11, 2024 21:03
@dotlambda dotlambda changed the title draft: add geospatial team to maintainers for geospatial packages where I'm a maintainer add geospatial team to maintainers for geospatial packages where I'm a maintainer Feb 11, 2024
@das-g das-g marked this pull request as ready for review February 11, 2024 23:29
@das-g das-g requested a review from imincik February 19, 2024 11:21
Copy link
Contributor

@imincik imincik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with taking those packages under our maintenance.

@imincik
Copy link
Contributor

imincik commented Feb 19, 2024

@das-g there is a conflict in pkgs/applications/misc/osmium-tool/default.nix

@das-g
Copy link
Member Author

das-g commented Feb 19, 2024

@das-g there is a conflict in pkgs/applications/misc/osmium-tool/default.nix

I'll look into it and will rebase.

@das-g das-g requested a review from imincik February 19, 2024 12:57
@imincik imincik merged commit b58efbc into NixOS:master Feb 22, 2024
22 checks passed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/week-in-geospatial-team/37035/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants