regclient: add shell completions and fix version output #288146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunet
force-pushed
the
feat/regclient/shell-completions
branch
3 times, most recently
from
925c482
to
9d606b9
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3463 |
maxbrunet
commented
Feb 22, 2024
maxbrunet
force-pushed
the
feat/regclient/shell-completions
branch
from
9d606b9
to
3f6aecb
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3552 |
Comment on lines
39
to
43
| export bin=''$${bin} | ||
| export outputBin=bin | ||
|
|
||
| mkdir -p $bin/bin | ||
| mv $out/bin/${bin} $bin/bin |
There was a problem hiding this comment.
I am not sure if this could be simplifed
maxbrunet
force-pushed
the
feat/regclient/shell-completions
branch
from
3f6aecb
to
92e56ee
Compare
maxbrunet
force-pushed
the
feat/regclient/shell-completions
branch
from
92e56ee
to
5881d2d
Compare
maxbrunet
force-pushed
the
feat/regclient/shell-completions
branch
from
5881d2d
to
ef0ed76
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3680 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
As in title
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.