lib.fileset.toList: init #288677
Merged
lib.fileset.toList: init #288677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-54/39990/1 |
infinisil
force-pushed
the
fileset.toList
branch
from
af2cb79
to
3ea077d
Compare
infinisil
force-pushed
the
fileset.toList
branch
2 times, most recently
from
4658b55
to
c5c908f
Compare
roberth
reviewed
Feb 26, 2024
| The resulting list of files can be turned back into a file set using [`lib.fileset.unions`](#function-library-lib.fileset.unions). | ||
|
|
||
| Type: | ||
| toList :: FileSet -> [ Path ] |
There was a problem hiding this comment.
Feel free to ignore.
Suggested change
| toList :: FileSet -> [ Path ] | |
| lib.fileset.toList :: FileSet -> [ Path ] |
There was a problem hiding this comment.
Yeah I'd like to keep it consistent with the other signatures, which is without the prefix.
infinisil
force-pushed
the
fileset.toList
branch
from
e466f88
to
e3a6e38
Compare
fricklerhandwerk
approved these changes
Feb 26, 2024
1 task
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds
lib.fileset.toListto turn a fileset into a list of its files as requested in #288592. See also this Discourse thread for the motivation.This work is sponsored by Antithesis ✨
Things done
Add a 👍 reaction to pull requests you find important.