Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rainbowcrack: init at 1.8 #288895

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rainbowcrack: init at 1.8 #288895

wants to merge 1 commit into from

Conversation

Tochiaha
Copy link
Contributor

@Tochiaha Tochiaha commented Feb 14, 2024 •
edited

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@Tochiaha
Copy link
Contributor Author

@AndersonTorres can I get a review

Tochiaha
Tochiaha commented Feb 15, 2024
View reviewed changes
Copy link
Contributor Author

@Tochiaha Tochiaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndersonTorres @999eagle

999eagle
999eagle suggested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@999eagle 999eagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The precompiled binaries don't run and need to be patchelf'd to set the correct linker path and rpath.

pkgs/by-name/ra/rainbowcrack/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ra/rainbowcrack/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ra/rainbowcrack/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ra/rainbowcrack/package.nix Outdated Show resolved Hide resolved
@Tochiaha
Copy link
Contributor Author

@AndersonTorres @999eagle

AndersonTorres
AndersonTorres suggested changes Feb 23, 2024
View reviewed changes
pkgs/by-name/ra/rainbowcrack/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ra/rainbowcrack/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ra/rainbowcrack/package.nix Outdated Show resolved Hide resolved
@Tochiaha
Copy link
Contributor Author

@AndersonTorres requested changes made everything works fine.

@Tochiaha Tochiaha force-pushed the origin/rainbowcrak branch 4 times, most recently from d08619c to a5eeed0 Compare March 9, 2024 06:47
@Tochiaha Tochiaha mentioned this pull request Apr 1, 2024
Open
13 tasks
@Tochiaha Tochiaha force-pushed the origin/rainbowcrak branch 2 times, most recently from a24032d to e1c08f7 Compare April 1, 2024 14:51
@Tochiaha Tochiaha changed the title rainbowcrack: init at 1.8-0kali1 rainbowcrack: init at 1.8 Apr 5, 2024
Aleksanaa
Aleksanaa reviewed Apr 9, 2024
View reviewed changes
pkgs/by-name/ra/rainbowcrack/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ra/rainbowcrack/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ra/rainbowcrack/package.nix Show resolved Hide resolved
pkgs/by-name/ra/rainbowcrack/package.nix Show resolved Hide resolved
Aleksanaa
Aleksanaa previously requested changes Apr 14, 2024
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needing meta.license

Aleksanaa
Aleksanaa reviewed Apr 14, 2024
View reviewed changes
pkgs/by-name/ra/rainbowcrack/package.nix Outdated
hash = "sha256-xMC9teHiDvBY/VHV63TsNQjdcuLqHGeXUyjHvRTO9HQ=";
};

buildInputs = [ alglib unzip ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be nativeBuildInputs, also where is alglib being used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is just a required lib but not actually used to build the package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buildInputs will not work in this case. There's no linker command in this derivation. You may need autoPatchelfHook with runtimeDependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes made stdenNoCC to stdenv, autoPatchelfHook and runtimedependencies added, this way is most preferred Thank you @Aleksanaa

@Tochiaha Tochiaha force-pushed the origin/rainbowcrak branch 2 times, most recently from 6f93384 to 438a11f Compare April 14, 2024 12:59
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirillrdy kirillrdy kirillrdy left review comments

@Aleksanaa Aleksanaa Aleksanaa left review comments

@AndersonTorres AndersonTorres AndersonTorres approved these changes

@999eagle 999eagle Awaiting requested review from 999eagle

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Tochiaha @nixos-discourse @kirillrdy @999eagle @AndersonTorres @Aleksanaa @delroth @wegank