rclone-python: init at 0.1.12 #288952
Open
rclone-python: init at 0.1.12 #288952
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaptainJawZ
force-pushed
the
rclone-python
branch
from
7eb1ed3
to
360d53e
Compare
dani0854
suggested changes
Jun 19, 2024
There was a problem hiding this comment.
Reviewed points
- package path fits guidelines
- package name fits guidelines
- package version fits guidelines
- package builds on x86_64-linux
-
meta.descriptionis set and fits guidelines -
meta.licensefits upstream license -
meta.maintainersis set - source is fetched using the appropriate function
| propagatedBuildInputs = [ rclone rich ]; | ||
|
|
||
| # tests require working internet connection | ||
| doCheck = false; |
There was a problem hiding this comment.
I couldn't find any tests at all in the source repository.
There was a problem hiding this comment.
Since there are no tests provided by the package, I guess pythonImportsCheck is a good thing to add.
https://nixos.org/manual/nixpkgs/stable/#using-pythonimportscheck
There was a problem hiding this comment.
Oh I didn't know about that check, I added it and it worked! rebased the commit.
CaptainJawZ
force-pushed
the
rclone-python
branch
from
360d53e
to
724c281
Compare
dani0854
approved these changes
Jun 24, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1774 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
A python module
pretty straight forward, I added rclone as a propagated build input, as this is a module required for it, however if the recommended way is for the user to install it separately, I can adjust the code as required.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.