Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spice-vdagent: add systemd support #28922

Merged
merged 1 commit into from
Sep 6, 2017

Conversation

offlinehacker
Copy link
Contributor

Motivation for this change

Support for systemd to spice-vdagent. This pull request should fix clipboard for spice.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@offlinehacker, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aboseley and @grahamc to be potential reviewers.

Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add to the commit message what "systemd support" brings.

@offlinehacker
Copy link
Contributor Author

I gave it a better description, but honestly i forgot what it fixed for me, but i assume, as systemd-logind is used on nixos, that clipboard did not work before this additional dependency, as it was not able to get user session information.

This change adds systemd as dependency to enable user session
integration with systemd-logind
@offlinehacker offlinehacker force-pushed the pkgs/spice-vdagent/systemd_support branch from a042567 to 3ca311d Compare September 3, 2017 14:15
@joachifm joachifm merged commit 9f11074 into NixOS:master Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants