Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.keepalived: fix eval (maintainers attribute) #289397

Merged
merged 1 commit into from Feb 17, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Feb 16, 2024

Without the change test sfails to evaluate as:

$ nix build --no-link -f. nixosTests.keepalived
error:
   error: function 'makeTest' called with unexpected argument 'maintainers'

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Without the change test sfails to evaluate as:

    $ nix build --no-link -f. nixosTests.keepalived
    error:
       error: function 'makeTest' called with unexpected argument 'maintainers'
@infinisil infinisil merged commit 7e1eefd into NixOS:master Feb 17, 2024
26 checks passed
@trofi trofi deleted the nixosTests.keepalived-fix-eval branch February 17, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants