Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i3: 4.13 -> 4.14 #28976

Merged
merged 2 commits into from
Sep 5, 2017
Merged

i3: 4.13 -> 4.14 #28976

merged 2 commits into from
Sep 5, 2017

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@NeQuissimus NeQuissimus changed the title I3 4 14 i3: 4.13 -> 4.14 Sep 4, 2017
@grahamc
Copy link
Member

grahamc commented Sep 4, 2017

Is this a mass rebuild? LGTM at any rate.

@NeQuissimus
Copy link
Member Author

@grahamc nox-review says it is not...

@Mic92
Copy link
Member

Mic92 commented Sep 4, 2017

definitely not a mass-rebuild.

@grahamc
Copy link
Member

grahamc commented Sep 4, 2017 via email

@Mic92
Copy link
Member

Mic92 commented Sep 4, 2017

When starting py3status from nix-shell. I get the error message, that i3status is not found. Probably this should be added to the PATH of the py3status command.

@NeQuissimus
Copy link
Member Author

NeQuissimus commented Sep 4, 2017

@Mic92 Have you used py3status with 4.13? It's build inputs seem strangely sparse to begin with...
I just left it the way it was...

@fpletz
Copy link
Member

fpletz commented Sep 5, 2017

py3status also works standalone (-s), so adding i3status is not strictly necessary.

@teto
Copy link
Member

teto commented Sep 5, 2017

it would be nice to have access to manpages. man i3bar doesn't work here but that might be because I use an overlay to compile i3 from a local repository (though I doubt so).

@NeQuissimus
Copy link
Member Author

@teto I think we can solve that in a separate PR, I am not sure how involved that would be.

@Mic92 Mic92 merged commit 69a9e87 into NixOS:master Sep 5, 2017
@fpletz
Copy link
Member

fpletz commented Sep 5, 2017

@teto Fixed in 101a048.

fpletz added a commit that referenced this pull request Sep 5, 2017
@teto
Copy link
Member

teto commented Sep 5, 2017

Cool thanks

fpletz added a commit that referenced this pull request Sep 5, 2017
cc #28976

(cherry picked from commit 101a048)
@NeQuissimus NeQuissimus deleted the i3_4_14 branch September 5, 2017 16:19
@NeQuissimus
Copy link
Member Author

@fpletz What a beast, just whips out the fix :D (Thx!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants