Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpackages.RcppCGAL: fixed build #289775

Closed
wants to merge 1 commit into from
Closed

rpackages.RcppCGAL: fixed build #289775

wants to merge 1 commit into from

Conversation

b-rodrigues
Copy link
Contributor

@b-rodrigues b-rodrigues commented Feb 18, 2024 •
edited
Loading

Description of changes

Fixed build

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Kupac
Kupac suggested changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@Kupac Kupac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise it looks OK

> RcppCGAL::cgal_version()
This package is bundled with CGAL version 5.6.
> RcppCGAL::cgal_is_installed()
[1] TRUE

pkgs/development/r-modules/default.nix Show resolved Hide resolved
@b-rodrigues b-rodrigues force-pushed the fix_rcppcgal branch 2 times, most recently from c25d0f1 to ba78fd0 Compare March 1, 2024 23:42
@b-rodrigues b-rodrigues marked this pull request as draft March 25, 2024 15:06
@b-rodrigues
Copy link
Contributor Author

Put to draft while waiting for results of latest evaluation

#298837

@b-rodrigues
Copy link
Contributor Author

fixed with: 120c0c1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kupac Kupac Kupac requested changes

@jbedo jbedo Awaiting requested review from jbedo jbedo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@b-rodrigues @Kupac