Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

grass: drop obsolete configure option #289948

Merged
merged 1 commit into from Feb 21, 2024

Conversation

imincik
Copy link
Contributor

@imincik imincik commented Feb 19, 2024

Description of changes

Drop obsolete --with-wxwidgets configure option.

Following message is printed during the build:

 grass> configure: WARNING: unrecognized options: --with-wxwidgets 

/cc @landam

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Drop obsolete `--with-wxwidgets` configure option.
@imincik imincik force-pushed the grass-drop-obsolete-with-wxwidgets branch from 14c4f48 to 1cf3530 Compare February 20, 2024 14:50
@imincik imincik changed the title pkgs(grass): drop obsolete configure option grass: drop obsolete configure option Feb 20, 2024
@landam
Copy link
Contributor

landam commented Feb 21, 2024

As one of GRASS devs I can approve this PR. The --with-wxwidgets configure option was removed in GRASS GIS version 8.3.0, see OSGeo/grass#2593

@imincik imincik merged commit 4d5d18e into NixOS:master Feb 21, 2024
25 checks passed
@imincik imincik deleted the grass-drop-obsolete-with-wxwidgets branch February 21, 2024 17:02
imincik added a commit to imincik/geospatial-nix that referenced this pull request Feb 22, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/week-in-geospatial-team/37035/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants