unbound: 1.19.2 pkg-config for protobuf-c #289979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcunat
requested changes
Feb 29, 2024
|
There was a followup: NLnetLabs/unbound#1006 |
|
I think the fix is NLnetLabs/unbound@3f51755 |
haraldh
force-pushed
the
unbound_pkg_config
branch
from
5c38a0c
to
fe60dc2
Compare
|
added both followup patches |
haraldh
force-pushed
the
unbound_pkg_config
branch
2 times, most recently
from
ff244ac
to
40aa666
Compare
haraldh
force-pushed
the
unbound_pkg_config
branch
3 times, most recently
from
1340595
to
acf5295
Compare
|
hmm.. ofborg-eval seems to be broken after rebasing to current staging |
|
@ofborg build unbound |
|
The eval problem ( |
|
@ofborg eval |
haraldh
force-pushed
the
unbound_pkg_config
branch
from
acf5295
to
078e4cb
Compare
|
haraldh
force-pushed
the
unbound_pkg_config
branch
from
078e4cb
to
bb8e7f2
Compare
|
rebased on current staging |
|
Maybe update to .2 instead of applying patches? Notably I see in announcement:
(I just assume that these patches are included; maybe they aren't. Anyway, that update sounds good to include.) |
Patched configure script with: NLnetLabs/unbound@59d98b9 Credits: @NickCao and followup patches fixing the patch. Enables multiple outputs for protobuf-c Signed-off-by: Harald Hoyer <harald@hoyer.xyz>
haraldh
force-pushed
the
unbound_pkg_config
branch
from
bb8e7f2
to
d29146c
Compare
haraldh
changed the title
|
rebased on 1.19.2 |
|
Works on linux, darwin we can only reasonable test in staging-next, anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Patched configure script with:
NLnetLabs/unbound@59d98b9 Credits: @NickCao
Enables multiple outputs for protobuf-c as in #283783
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.