stremio: add ffmpeg as runtime dependency to PATH #290070
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Stremio depends on
ffmpeg
for features such as streaming to a chromecast. Withoutffmpeg
, when trying to stream to a chromecast, it never loads, when adding ffmpeg toPATH
(for example in an ad-hoc nix shell), the feature works fine.So, this PR wraps the derivation executable with
ffmpeg
binaries added toPATH
.This dependency can also be confirmed by seeing some of the official build scripts, that list both the
ffmpeg
andffprobe
(the latter is also included in theffmpeg
package) binaries:I also split the derivation arguments into multiple lines, as the list was already pretty long, and I had to add a new dependency.
Another missing dependency seems to be
openssl
. However, when searching the code, it seems only to be used for the autoupdate feature, which will not be useful in the nix package, so I believe it would be fine to not include it.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.