Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

stremio: add ffmpeg as runtime dependency to PATH #290070

Merged
merged 2 commits into from Mar 22, 2024

Conversation

rafaelrc7
Copy link
Member

Description of changes

Stremio depends on ffmpeg for features such as streaming to a chromecast. Without ffmpeg, when trying to stream to a chromecast, it never loads, when adding ffmpeg to PATH (for example in an ad-hoc nix shell), the feature works fine.

So, this PR wraps the derivation executable with ffmpeg binaries added to PATH.

This dependency can also be confirmed by seeing some of the official build scripts, that list both the ffmpeg and ffprobe (the latter is also included in the ffmpeg package) binaries:

I also split the derivation arguments into multiple lines, as the list was already pretty long, and I had to add a new dependency.

Another missing dependency seems to be openssl. However, when searching the code, it seems only to be used for the autoupdate feature, which will not be useful in the nix package, so I believe it would be fine to not include it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@rafaelrc7
Copy link
Member Author

I also added the backport release-23.11 as this fixes a derivation bug, as described above, and so I believe it should be backported when merged.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3634

@rafaelrc7 rafaelrc7 force-pushed the stremio/missing-dependencies branch from ad14adc to b6c9a61 Compare March 21, 2024 02:10
@kirillrdy kirillrdy merged commit b58ef70 into NixOS:master Mar 22, 2024
22 of 23 checks passed
Copy link
Contributor

Successfully created backport PR for release-23.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants