New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
gdal: Split tests into separate attributes #290298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not put the multiple attributes in tests.nix
?
40c1886
to
5d3e8f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with this change, even though I haven't seen this pattern anywhere else (do you know about any other package splitting tests in similar way ?) Also, more use of testers and lib functions is good thing as well.
I don't know where I picked it up (The documentation? Some other random package?), but looking for packages with more than one test in
This finds a bunch:
|
@dotlambda , are you ok with merging this PR as it is now ? |
Makes it easier to run single tests for debugging purposes. Co-authored-by: Robert Sch眉tz <github@dotlambda.de>
2d37b3b
to
de01ad8
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/week-in-geospatial-team/37035/8 |
Description of changes
Makes it easier to run single tests for debugging purposes.
Preparation for adding more tests in #290292.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-build -A gdal.passthru.tests
)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.