pterodactyl-wings and nixos/pterodactyl-wings: init at 1.11.8 #290495
Conversation
melvyn2
force-pushed
the
pt-wings
branch
4 times, most recently
from
c04ba34
to
1b6de25
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3651 |
| default = 8080; | ||
| description = "The port that the internal webserver should bind to."; | ||
| }; | ||
| ssl = { |
There was a problem hiding this comment.
We should nudge people to use the acme module
| }; | ||
| log_directory = mkOption { | ||
| type = path; | ||
| default = "/var/log/pterodactyl"; |
There was a problem hiding this comment.
We cannot log to journald?
There was a problem hiding this comment.
The daemon also logs to stdout, and so journald captures the output. I didn't see a way to disable file logging, so I left the option.
There was a problem hiding this comment.
Can we redirect the file logging to /dev/log which ends up in journald?
There was a problem hiding this comment.
I think that would end up double-logging because it would duplicate the stdout logging. The daemon also logs to arbitrary files in the directory, which I'm not sure how to redirect.
| }; | ||
| }; | ||
| docker = { | ||
| network = { |
There was a problem hiding this comment.
Should we assert this with the options for docker/podman?
There was a problem hiding this comment.
Not sure how to handle this with services that don't use the nixos options to manage their networks (like this one), and even then which nixos options would show the locally assigned options.
Description of changes
Wings is the server-managing daemon for nodes of the Pterodactyl game server management system.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.