Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/borgmatic: added test #290913

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

nixos/borgmatic: added test #290913

wants to merge 2 commits into from
+56 −18

Conversation

flandweber
Copy link
Contributor

@flandweber flandweber commented Feb 23, 2024 •
edited
Loading

Added validation of borgmatic config to system.checks to test it at build time.
Added basic nixos test to ensure functionality.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@flandweber
Copy link
Contributor Author

@ofborg test borgmatic

@flandweber
nixos/borgmatic: added test
a71502a
@flandweber
nixos/borgmatic: refactor
9d94b98 
added configuration check at built time
added borgmatic.enableConfigCheck whether or not it'll be executed.
imlonghao
imlonghao approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@imlonghao imlonghao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imlonghao imlonghao imlonghao approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12.approvals: 1 needs_merger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flandweber @nixos-discourse @imlonghao