tic-80: init at 1.1.2837 #291129
tic-80: init at 1.1.2837 #291129
Conversation
|
@winny- I'd love to add you as a co-maintainer! Would you like that? I didn't see you in nixpkgs' maintainer file yet, so if you'd want details like email address, github handle/id or other contact options listed there, let me know! (But all of these are optional.) |
|
Also pinging @pinkcreeper100, @CyborgPotato and @Serif-7, maybe you'd like to help review or test? :) |
|
tried to run this and got a mismatched hash |
|
@pinkcreeper100 Thanks for testing! Ah dang! That might be #8567 at work… Could you check whether Alternatively, we could fall back to @winny-'s original solution to just hardcode the revision number in the CMake build process... |
|
the directory doesn't exist |
pkgs/by-name/ti/tic-80/package.nix
Outdated
|
|
||
| cmakeFlags = [ "-DBUILD_PRO=On" "-DBUILD_SDLGPU=On" ]; | ||
| enableParallelBuilding = true; | ||
| dontStrip = true; |
There was a problem hiding this comment.
we should add a short reason with why
There was a problem hiding this comment.
My thought was that it'd be required for the rpath patching. But I tried without it, and it didn't seem to make a difference? So I guess we can remove it until we find it's required.
|
Thanks for your detailed review, @SuperSandro2000! 🎉 I addressed all your points in a follow-up commit (which we could squash once we merge this PR). All except one: Using the vendored libraries seems much less complicated right now compared to re-modelling the compilation process to allow using Nix' versions. |
Hi there, thanks for asking! I'm unable to support nixpkgs work at this time. |
|
I removed the requirement to use |
|
@SuperSandro2000 hi, are there any additional review items? |
|
Could you squash the fixups into the original commits? |
|
Result of 1 package built:
I don't have any games to test but it appears to run as expected. With a delightful startup sound too :) |
Done :) (Sorry for the notification, @mmahut & @RaghavSood, your review is not required.) |
| src = fetchFromGitHub { | ||
| owner = "nesbox"; | ||
| repo = "TIC-80"; | ||
| rev = "v" + version; |
There was a problem hiding this comment.
Nit: String interpolation is usually preferred to concatenation.
Description of changes
TIC-80 is a "fantasy console" for making, playing and sharing tiny games. See the packaging request #200260.
This is based on @winny-'s private package, which I updated to the latest release, and their kind permission to take it and contribute it to nixpkgs.
This is not a particularly elegant package, because TIC-80 vendors a lot of its dependencies. Especially the SDL2 and mruby dependencies require workarounds. In the long term, maybe we could upstream options to TIC-80's CMake build process to use Nix' libraries instead of building them from scratch. But for now, I like this how it is.
How to try out this package
If you have enabled Flakes, you simply can try running the following command:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.