Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtiff: don't propagate unnecessary build inputs #291657

Closed
wants to merge 3 commits into from

Conversation

imincik
Copy link
Contributor

@imincik imincik commented Feb 26, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@imincik imincik mentioned this pull request Feb 26, 2024
13 tasks
@ofborg ofborg bot requested a review from MarcWeber February 26, 2024 21:59
@imincik
Copy link
Contributor Author

imincik commented Feb 27, 2024

I tried to run nixpkgs-review , but it wants to build 55k of packages, which is impossible for me.

@imincik
Copy link
Contributor Author

imincik commented Mar 1, 2024

This PR is replaced with #292568 due to my mistake with incorrect source branch name (which can't be changed).

@imincik imincik closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants