Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cask: 0.8.8 -> 0.9.0 #291970

Closed
wants to merge 3 commits into from
Closed

cask: 0.8.8 -> 0.9.0 #291970

wants to merge 3 commits into from

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Feb 28, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@AndersonTorres
cask: migrate to by-name
0d4c404 
Also, keep a green alias in order to not break things.
@AndersonTorres
cask: refactor
b209222 
- makeWrapper instead of symlink
- get rid of nested with
- set meta.mainProgram
@AndersonTorres
cask: 0.8.8 -> 0.9.0
929254c
@AndersonTorres AndersonTorres marked this pull request as ready for review February 28, 2024 02:17
@vdemeester
Copy link
Member

Result of nixpkgs-review pr 291970 run on x86_64-linux 1

1 package built:
  • cask (emacsPackages.cask)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1515

vdemeester
vdemeester approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃惎

@AndersonTorres AndersonTorres marked this pull request as draft April 16, 2024 11:32
@AndersonTorres
Copy link
Member Author

Another conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis adisbladis is a code owner

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: emacs 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AndersonTorres @vdemeester @nixos-discourse @wegank