Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport 23.11] patch2pr: init at 0.22.0 #292263

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

katrinafyi
Copy link
Member

@katrinafyi katrinafyi commented Feb 29, 2024

Description of changes

backport of #291104 (auto-backport failed at #292179).

this only adds the new patch2pr leaf package. quoted from earlier pr:

https://github.com/bluekeyes/patch2pr

patch2pr creates pull requests from patch files. it uses the Github API to create PRs without needing a repo checkout.

the package is a fairly simple go package.

testing functionality will need a GITHUB_TOKEN. assuming you have a nixpkgs fork and a token with write permissions on this fork, you can test this with:

wget -O test.patch https://github.com/NixOS/nixpkgs/pull/291104.patch
GITHUB_TOKEN=github_pat_...   patch2pr -repository NixOS/nixpkgs -fork -patch-base 2ea79083c54ea7a665562c1c41b0e18d9a9ff72e -json -no-pull-request ./test.patch

this should make a branch called "patch2pr" in your fork with this pull request applied. with more permissions, you can test without -no-pull-request.

there is also a simple testVersion:

nix build .#patch2pr.tests.patch2pr-version

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3544

@katrinafyi
Copy link
Member Author

@AndersonTorres do you mind taking a look? Your help was appreciated with the original PR.

Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 292263 run on x86_64-linux 1

1 package built:
  • patch2pr

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1513

@emilytrau emilytrau merged commit fa9f817 into NixOS:release-23.11 Mar 19, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants