Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruff: 0.2.2 -> 0.3.0 #292359

Merged
merged 1 commit into from
Mar 5, 2024
Merged

ruff: 0.2.2 -> 0.3.0 #292359

merged 1 commit into from
Mar 5, 2024

Conversation

funkeleinhorn
Copy link
Contributor

Description of changes

Updated ruff from 0.2.2 to 0.3.0 as new version was released: https://github.com/astral-sh/ruff/releases/tag/v0.3.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@funkeleinhorn
Copy link
Contributor Author

@figsoda

@ofborg ofborg bot requested a review from figsoda February 29, 2024 17:09
@jnsgruk
Copy link
Member

jnsgruk commented Feb 29, 2024

Result of nixpkgs-review pr 292359 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python312Packages.pyhanko
  • python312Packages.pyhanko.dist
  • python312Packages.xhtml2pdf
  • python312Packages.xhtml2pdf.dist
6 packages failed to build:
  • nbqa
  • nbqa.dist
  • python312Packages.pytest-examples
  • python312Packages.pytest-examples.dist
  • python312Packages.xsdata
  • python312Packages.xsdata.dist
20 packages built:
  • dmarc-metrics-exporter
  • dmarc-metrics-exporter.dist
  • emacsPackages.lsp-bridge
  • maigret
  • maigret.dist
  • python311Packages.pyhanko
  • python311Packages.pyhanko.dist
  • python311Packages.pytest-examples
  • python311Packages.pytest-examples.dist
  • python311Packages.python-lsp-ruff
  • python311Packages.python-lsp-ruff.dist
  • python311Packages.xhtml2pdf
  • python311Packages.xhtml2pdf.dist
  • python311Packages.xsdata
  • python311Packages.xsdata.dist
  • ruff
  • ruff-lsp
  • ruff-lsp.dist
  • sasview
  • sasview.dist

@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 292359 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python312Packages.pyhanko
  • python312Packages.pyhanko.dist
  • python312Packages.xhtml2pdf
  • python312Packages.xhtml2pdf.dist
6 packages failed to build:
  • nbqa
  • nbqa.dist
  • python312Packages.pytest-examples
  • python312Packages.pytest-examples.dist
  • python312Packages.xsdata
  • python312Packages.xsdata.dist
23 packages built:
  • dmarc-metrics-exporter
  • dmarc-metrics-exporter.dist
  • emacsPackages.lsp-bridge
  • maigret
  • maigret.dist
  • python311Packages.pyhanko
  • python311Packages.pyhanko.dist
  • python311Packages.pytest-examples
  • python311Packages.pytest-examples.dist
  • python311Packages.python-lsp-ruff
  • python311Packages.python-lsp-ruff.dist
  • python311Packages.xhtml2pdf
  • python311Packages.xhtml2pdf.dist
  • python311Packages.xsdata
  • python311Packages.xsdata.dist
  • ruff
  • ruff-lsp
  • ruff-lsp.dist
  • sasview
  • sasview.dist
  • tests.testers.nixosTest-example
  • tests.testers.runNixOSTest-example
  • tests.trivial-builders.references

@funkeleinhorn
Copy link
Contributor Author

funkeleinhorn commented Mar 1, 2024 •
edited

I included the changelog in the commit message. Also I looked into nbqa and it was failing to build as the test_ruff_check was failing as ruff 0.3.0 deprecated ruff <path>. I added this test to the disabledTests section and opened an issue upstream. The nbqa package now builds for me. @l0b0 can you please confirm this changes to your package work and are okay. Probably the other packages failing to build for similar reasons. How to deal with them? I will later look into them and try to find fixes for them. If someone else wants to do that feels free to look into it and comment the failing parts/fixes here and I will include them ins this PR. Should fixing this packages happen inside this PR or should a dedicated PR be opened for each?

@ofborg ofborg bot requested a review from l0b0 March 1, 2024 14:43
@funkeleinhorn funkeleinhorn mentioned this pull request Mar 1, 2024
Closed
@funkeleinhorn
Copy link
Contributor Author

funkeleinhorn commented Mar 1, 2024 •
edited

@fabaff python312Packages.pytest-examples also fails to build on current master on x86_darwin:

pytest_examples/traceback.py:81: DeprecationWarning
=========================== short test summary info ============================
FAILED tests/test_run_examples.py::test_run_example_ok_fail - AssertionError: assert ['test_run_ex...arnings.html'] == ['', '>   ass...se...
FAILED tests/test_run_examples.py::test_run_directly - DeprecationWarning: co_lnotab is deprecated, use co_lines instead.
============ 2 failed, 69 passed, 1 deselected, 1 xfailed in 2.76s =============

building python312Packages.pytest-examples on 1c37aef fails with the same test failures.

@funkeleinhorn
Copy link
Contributor Author

funkeleinhorn commented Mar 1, 2024 •
edited

@dotlambda building python312Packages.xsdata fails for me on the current master on x86_darwin with the following error:

tests/formatter/test_do_format_code.py:151: AssertionError
=========================== short test summary info ============================
FAILED tests/test_docformatter.py::TestEndToEndPyproject::test_no_pre_summary_space_using_pyproject[arguments0-[tool.docformatter]\npre-summary-space = false\n-            class TestFoo():\n                """Docstring that should not have a pre-summary space."""\n            ] - assert '@@ -1,3 +1,2...           \n' == ''
FAILED tests/formatter/test_do_format_code.py::TestDoFormatCode::test_format_code_strip_blank_line_after_module_variable[args0] - assert '    CONST = ...r CONST."""\n' == '    CONST = ...NST."""\n    '
FAILED tests/formatter/test_do_format_code.py::TestDoFormatCode::test_format_code_class_docstring[args0] - assert '    class Te...        """\n' == '    class Te...    """\n    '
FAILED tests/formatter/test_do_format_code.py::TestDoFormatCode::test_format_code_strip_blank_line_after_class_variable[args0] - assert '    class Te...cstring."""\n' == '    class Te...ing."""\n    '
=================== 4 failed, 272 passed, 1 xfailed in 4.50s ===================

building python312Packages.xsdata on 1c37aef fails with the same test failures.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1496

@funkeleinhorn
Copy link
Contributor Author

Removed patches to nbqa as they where fixed upstream and nbqa was updated in nixpkgs in a seperated commit which is already merged to master: #293085

@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 292359 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python312Packages.pyhanko
  • python312Packages.pyhanko.dist
  • python312Packages.xhtml2pdf
  • python312Packages.xhtml2pdf.dist
4 packages failed to build:
  • python312Packages.pytest-examples
  • python312Packages.pytest-examples.dist
  • python312Packages.xsdata
  • python312Packages.xsdata.dist
22 packages built:
  • dmarc-metrics-exporter
  • dmarc-metrics-exporter.dist
  • emacsPackages.lsp-bridge
  • maigret
  • maigret.dist
  • nbqa
  • nbqa.dist
  • python311Packages.pyhanko
  • python311Packages.pyhanko.dist
  • python311Packages.pytest-examples
  • python311Packages.pytest-examples.dist
  • python311Packages.python-lsp-ruff
  • python311Packages.python-lsp-ruff.dist
  • python311Packages.xhtml2pdf
  • python311Packages.xhtml2pdf.dist
  • python311Packages.xsdata
  • python311Packages.xsdata.dist
  • ruff
  • ruff-lsp
  • ruff-lsp.dist
  • sasview
  • sasview.dist

@funkeleinhorn
Copy link
Contributor Author

building python312Packages.xsdata fails on current master too as building its dependecy python312Packages.docformatter fails building because some of its tests fail. I have a patch which disables these tests for now and gets the two packages to build again. Should I include this here or make a seperate PR? @dotlambda

@funkeleinhorn
Copy link
Contributor Author

I created a PR to fix python312Packages.xsdata dependecies preventing it from building #293284 and created another PR to fix python312Packages.pytest-examples #293285. Both where tested against the current master and this PRs HEAD. I think this PR should be ready to go as the not building packets are unrelated. Please review.

@SuperSandro2000
Copy link
Member

Failures are already on master

@SuperSandro2000 SuperSandro2000 merged commit e274f3c into NixOS:master Mar 5, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0b0 l0b0 l0b0 approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@figsoda figsoda Awaiting requested review from figsoda

@NickCao NickCao Awaiting requested review from NickCao

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12.approvals: 1 12.approved-by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@funkeleinhorn @jnsgruk @GaetanLepage @nixos-discourse @SuperSandro2000 @l0b0 @delroth