Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zlog: apply patch for CVE-2024-22857 #292517

Merged
merged 1 commit into from Mar 1, 2024
Merged

zlog: apply patch for CVE-2024-22857 #292517

merged 1 commit into from Mar 1, 2024

Conversation

LeSuisse
Copy link
Contributor

@LeSuisse LeSuisse commented Mar 1, 2024

Description of changes

Upstream PR: HardySimpson/zlog#251

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • zlog

Add a 馃憤 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from matthiasbeyer March 1, 2024 10:54
matthiasbeyer
matthiasbeyer approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit is on the master branch of upstream, so this should be fine.

risicle
risicle approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review happy, nixos x86_64. Builds, aarch64-linux & pkgsi686Linux variant. Already broken on macos.

@risicle risicle merged commit 0267739 into NixOS:master Mar 1, 2024
30 of 31 checks passed
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Successfully created backport PR for release-23.11:

@LeSuisse LeSuisse deleted the zlog-CVE-2024-22857 branch March 2, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@risicle risicle risicle approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 12.approved-by: package-maintainer backport release-23.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LeSuisse @matthiasbeyer @risicle @delroth