nixos/amazon-ec2-amis: Add NixOS 23.11

[arianvp]

Description of changes

These were uploaded by https://github.com/NixOS/amis

Note that this list will stop being updated from now on. Please use https://nixos.github.io/amis/ and https://nixos.github.io/amis/images.json instead. We are working on integrating this in the https://nixos.org/ website These get updated for every channel bump.

This should be enough to get the website listing them again. But we'll work to get the website get the data from https://nixos.github.io/amis/ for 24.05

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/ami-for-nixos-23-11/36860/8

[arianvp]

This might warrant a release note. But how does that work with backports? Do I want to backport the release note too?

[zimbatm]

Yeah, that would make sense to me. People looking at the 23.11 release note want to find the AMIs.

[arianvp]

I now added release notes to both 23.11 and 24.05. I'm not sure if this is the "right" way to do it? Should I only add the 23.11 release notes on the 23.11 release branch? Or what is etiquette here?

[zimbatm]

LGTM

[AleXoundOS]

@arianvp, how do these 2 differ and why this PR included older version (nixos/23.11.4976.79baff8812a0-x86_64-linux) rather than newer (nixos/23.11.5060.617579a78725-x86_64-linux)?

[arianvp]

Basically AMIs are constantly uploaded now for every channel bump. They differ in that the one is newer than the other.

The one on the PR is the one uploaded at the time of the PR. The amis are automatically kept up to date.

I am not gonna update amazon-ec2-amis.nix anymore.

If you want to find out the latest AMI use the website in question.

[AleXoundOS]

@arianvp, thank you very much for the explanation. It's clear now.

[arianvp]

I can maybe add a toggle to the website to only show the latest AMI by default.

[AleXoundOS]

@arianvp, maybe it would be even better to put the explanation above onto the website page. I mean: when (and maybe how) NixOS AMIs get built to be published on https://nixos.github.io/amis/. Also, brief explanation of the correlation with amazon-ec2-amis.nix and its destiny can help for those who were unaware.