emacs: Add feature flags #293050
Merged
emacs: Add feature flags #293050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbx
approved these changes
Mar 6, 2024
|
Could you add the |
Sure, but that will be staging change then. |
KAction
force-pushed
the
contrib/0/feature-emacs/out
branch
from
4f97a7e
to
43f440f
Compare
github-actions
bot
added
6.topic: python
6.topic: nixos
6.topic: kernel
8.has: documentation
8.has: changelog
6.topic: rust
6.topic: golang
6.topic: vim
6.topic: steam
6.topic: stdenv
ofborg
bot
added
10.rebuild-darwin-stdenv
10.rebuild-linux-stdenv
8.has: clean-up
8.has: package (new)
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 0
10.rebuild-darwin-stdenv
10.rebuild-linux-stdenv
labels
ofborg
bot
requested review from
jwiegley,
AndersonTorres,
lovek323 and
matthewbauer
|
Stdenv depenends on emacs?! |
AndersonTorres
suggested changes
Mar 7, 2024
Maybe staging is buggy again. |
Previously, these features were enabled unconditionally on linux.
KAction
force-pushed
the
contrib/0/feature-emacs/out
branch
from
43f440f
to
1ce934f
Compare
Done |
AndersonTorres
approved these changes
Mar 8, 2024
|
P.S.: can this PR be merged right before mine, that adds mailutils? Merging things is hard, merging thing on staging is a bit harder. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1515 |
|
Hi @AndersonTorres, currently only focusing on merging already reviewed PRs; hopefully will be able to review + merge 291209 during the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.