steam: add extraCompatPackages #293564
Merged
steam: add extraCompatPackages #293564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Atemu
approved these changes
Mar 6, 2024
nixos/modules/programs/steam.nix
Outdated
Comment on lines
80
to
81
| luxtorpeda | ||
| proton-ge |
There was a problem hiding this comment.
Are these two in Nixpkgs? If not, remove them or add a note about that and where to get these.
There was a problem hiding this comment.
as written in the pr description, there is no proton derivation in nixpkgs atm, so i removed that.
Shawn8901
force-pushed
the
steam-compat-tools
branch
2 times, most recently
from
92d878b
to
d24c0d5
Compare
Shawn8901
force-pushed
the
steam-compat-tools
branch
from
d24c0d5
to
93a891f
Compare
thiagokokada
approved these changes
Mar 8, 2024
K900
added a commit
to K900/nixpkgs
that referenced
this pull request
Mar 8, 2024
K900
added a commit
that referenced
this pull request
Mar 8, 2024
nixos/steam: fix eval after #293564
This was referenced Mar 9, 2024
13 tasks
|
Successfully created backport PR for |
1 task
|
@Lord-Valen be aware that there is some refactoring ongoing for improving how compat tools could be defined, not sure if that should go to stable alone. see #296009 |
Lord-Valen
pushed a commit
to Lord-Valen/nixpkgs
that referenced
this pull request
Mar 17, 2024
(cherry picked from commit 7b8d88f)
13 tasks
Lord-Valen
added
the
8.has: port to stable
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-23.11
git worktree add -d .worktree/backport-293564-to-release-23.11 origin/release-23.11
cd .worktree/backport-293564-to-release-23.11
git switch --create backport-293564-to-release-23.11
git cherry-pick -x 93a891f0e8e0feb96090eac48d9a2d5aaad28f20 |
zeme-wana
pushed a commit
to input-output-hk/nixpkgs
that referenced
this pull request
May 8, 2024
(cherry picked from commit 7b8d88f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds an extra option for the steam module to define compat tools via declaration.
One has to provide a valid proton derivation to let it appear in the steams proton list.
What defines a valid proton derivation could be looked up here: https://gitlab.steamos.cloud/steamrt/steam-runtime-tools/-/blob/393bb134fc01f96d68925d6bfe300d58b97744ac/docs/steam-compat-tool-interface.md
This supersedes #189398. The option declaration is the same, but does not apply the environment variable globally but just on the steam wrapper.
For testing purposes one could either use the proton-ge that is have in my personal flake https://github.com/Shawn8901/nix-configuration/blob/main/packages/proton-ge-custom/default.nix or that one which is in the NUR https://github.com/nix-community/nur-combined/blob/master/repos/ataraxiasjel/pkgs/proton-ge/default.nix
sadly there is at the moment no custom proton runtime in nixpkgs at the moment (or at least i did not find any).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.