Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knock: init at 0.0.2 #294140

Merged
merged 4 commits into from Mar 8, 2024
Merged

knock: init at 0.0.2 #294140

merged 4 commits into from Mar 8, 2024

Conversation

nat-418
Copy link
Contributor

@nat-418 nat-418 commented Mar 7, 2024

Description of changes

knock is a simple, command-line network reachability tester.

Homepage: https://github.com/nat-418/knock

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3596

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Often can ldflags help to get smaller binaries.

  ldflags = [
    "-w"
    "-s"
  ];

pkgs/tools/networking/knock/package.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/knock/package.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/knock/package.nix Outdated Show resolved Hide resolved
nat-418 and others added 3 commits March 8, 2024 09:51
Co-authored-by: Fabian Affolter <mail@fabian-affolter.ch>
Co-authored-by: Fabian Affolter <mail@fabian-affolter.ch>
Co-authored-by: Fabian Affolter <mail@fabian-affolter.ch>
@nat-418
Copy link
Contributor Author

nat-418 commented Mar 8, 2024

Often can ldflags help to get smaller binaries.

  ldflags = [
    "-w"
    "-s"
  ];

Interesting. Could you explain a bit more here? What are the tradeoffs of disabling the symbol table and DWARF generation?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Mar 8, 2024

It is basically stripping to make the binary not as huge

@SuperSandro2000 SuperSandro2000 merged commit a51e98b into NixOS:master Mar 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants