-
-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/gatus: init module #294469
base: master
Are you sure you want to change the base?
nixos/gatus: init module #294469
Conversation
Hi! Welcome and thank you for your first contribution :) Please squash your commits into a single commit and use a proper commit message. |
I noticed that gatus also supports postgresql as a storage backend, an option for that would be nice, but could also be done in a future PR (and also by someone else, if you don't plan to use it). |
none of this is killer so felt iffy for review buuut |
Indeed, for my use case SQLite is more than enough, so I'd say we can leave this for a future PR of (probably) someone else :) Does seem like a good idea though. |
40a539a
to
9235a7f
Compare
Thanks for all the reviews! Unless there are further comments I think this might be ready for a merge? |
i have one small thing, would be nice if you could create an extra commit for creating your maintainer in maintainer-list.nix |
Done and done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hello @pizzapim thanks for the work you put in this PR. What’s left to do before it gets merged? |
The merge conflict needs to be resolved by rebasing on master, then it should be ready to merge |
819aee9
to
b46c362
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4005 |
@drupol, sorry for the ping. The changes you requested have been made. |
@@ -95,6 +95,8 @@ The pre-existing [services.ankisyncd](#opt-services.ankisyncd.enable) has been m | |||
|
|||
- [GNS3](https://www.gns3.com/), a network software emulator. Available as [services.gns3-server](#opt-services.gns3-server.enable). | |||
|
|||
- [Gatus](https://github.com/TwiN/gatus), an automated developer-oriented status page. Available as [services.gatus](#opt-services.gatus.enable). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this supposed to nixos/doc/manual/release-notes/rl-2411.section.md
?
Description of changes
In #269477, the Gatus package was added to nixpkgs. I created a NixOS module to run Gatus as a Systemd service. I have been running this myself for a week with no problems. You can see on my personal Git server how this can be used: here I define Gatus endpoints which are services I monitor, and here I configure the service itself.
This is my first contribution to nixpkgs so any comments are greatly appreciated!
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.