Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

magic-enum: 0.8.2 -> 0.9.5 #294551

Merged
merged 1 commit into from Mar 11, 2024
Merged

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Mar 9, 2024

Description of changes

Changelog: https://github.com/Neargye/magic_enum/releases/tag/v0.9.5

I faced the issue described in #144170 but fixed it by doing the same thing as in #71669.

Also, I re-enabled the tests as they have since been fixed.

cc @Alper-Celik

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@GaetanLepage GaetanLepage changed the title magic-enum: 0.8.5 -> 0.9.5 magic-enum: 0.8.2 -> 0.9.5 Mar 9, 2024
@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 294551 run on aarch64-linux 1

1 package failed to build:
  • kemai
11 packages built:
  • lua51Packages.rocks-nvim
  • lua51Packages.toml
  • lua52Packages.rocks-nvim
  • lua52Packages.toml
  • lua53Packages.rocks-nvim
  • lua53Packages.toml
  • lua54Packages.rocks-nvim
  • lua54Packages.toml
  • luajitPackages.rocks-nvim
  • luajitPackages.toml
  • magic-enum

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 294551 run on aarch64-darwin 1

1 package marked as broken and skipped:
  • kemai
5 packages failed to build:
  • lua51Packages.rocks-nvim
  • lua52Packages.rocks-nvim
  • lua53Packages.rocks-nvim
  • lua54Packages.rocks-nvim
  • luajitPackages.rocks-nvim
6 packages built:
  • lua51Packages.toml
  • lua52Packages.toml
  • lua53Packages.toml
  • lua54Packages.toml
  • luajitPackages.toml
  • magic-enum

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 294551 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • kemai
5 packages failed to build:
  • lua51Packages.rocks-nvim
  • lua52Packages.rocks-nvim
  • lua53Packages.rocks-nvim
  • lua54Packages.rocks-nvim
  • luajitPackages.rocks-nvim
6 packages built:
  • lua51Packages.toml
  • lua52Packages.toml
  • lua53Packages.toml
  • lua54Packages.toml
  • luajitPackages.toml
  • magic-enum

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 294551 run on x86_64-linux 1

1 package failed to build:
  • kemai
11 packages built:
  • lua51Packages.rocks-nvim
  • lua51Packages.toml
  • lua52Packages.rocks-nvim
  • lua52Packages.toml
  • lua53Packages.rocks-nvim
  • lua53Packages.toml
  • lua54Packages.rocks-nvim
  • lua54Packages.toml
  • luajitPackages.rocks-nvim
  • luajitPackages.toml
  • magic-enum

@GaetanLepage
Copy link
Contributor Author

Actually, something is still wrong.
The old derivation contained the following:

include  lib  share

while the new one contains:

include  nixstoreyxyp0l312bpmxrjiy4xwv8i0wwmlx3vf-magic-enum-0.9.5lib  share

So there is obviously some CMake magic that is escaping the / from the output path...

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 294551 run on aarch64-darwin 1

1 package marked as broken and skipped:
  • kemai
5 packages failed to build:
  • lua51Packages.rocks-nvim
  • lua52Packages.rocks-nvim
  • lua53Packages.rocks-nvim
  • lua54Packages.rocks-nvim
  • luajitPackages.rocks-nvim
6 packages built:
  • lua51Packages.toml
  • lua52Packages.toml
  • lua53Packages.toml
  • lua54Packages.toml
  • luajitPackages.toml
  • magic-enum

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 294551 run on x86_64-linux 1

12 packages built:
  • kemai
  • lua51Packages.rocks-nvim
  • lua51Packages.toml
  • lua52Packages.rocks-nvim
  • lua52Packages.toml
  • lua53Packages.rocks-nvim
  • lua53Packages.toml
  • lua54Packages.rocks-nvim
  • lua54Packages.toml
  • luajitPackages.rocks-nvim
  • luajitPackages.toml
  • magic-enum

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 294551 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • kemai
5 packages failed to build:
  • lua51Packages.rocks-nvim
  • lua52Packages.rocks-nvim
  • lua53Packages.rocks-nvim
  • lua54Packages.rocks-nvim
  • luajitPackages.rocks-nvim
6 packages built:
  • lua51Packages.toml
  • lua52Packages.toml
  • lua53Packages.toml
  • lua54Packages.toml
  • luajitPackages.toml
  • magic-enum

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 294551 run on aarch64-linux 1

12 packages built:
  • kemai
  • lua51Packages.rocks-nvim
  • lua51Packages.toml
  • lua52Packages.rocks-nvim
  • lua52Packages.toml
  • lua53Packages.rocks-nvim
  • lua53Packages.toml
  • lua54Packages.rocks-nvim
  • lua54Packages.toml
  • luajitPackages.rocks-nvim
  • luajitPackages.toml
  • magic-enum

@GaetanLepage
Copy link
Contributor Author

luaPackages.rocks-nvim is not bulding on darwin on master either because luaPackages.toml-edit is broken there.

Copy link
Member

@Alper-Celik Alper-Celik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. i tested it on my project i originally packaged it for. there doesn't seem to be any problems.

@SuperSandro2000
Copy link
Member

@ofborg eval

@ofborg ofborg bot requested a review from Alper-Celik March 11, 2024 13:49
@SuperSandro2000 SuperSandro2000 merged commit 733109a into NixOS:master Mar 11, 2024
26 of 28 checks passed
@GaetanLepage GaetanLepage deleted the magic-enum branch March 11, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants