-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.asyncpg: fix build and bump minimum Python version #294645
Conversation
Result of 6 packages failed to build:
28 packages built:
The build failures are unrelated to this PR (they fail to build on master as well), so I think those packages are broken. |
But latest build https://hydra.nixos.org/build/252816345 is OK. What is broken? |
It seems like it doesn't fail in |
It's failing in versions prior to 3.11 specifically because of this compatibility code that imports |
Ah, looks like the minimum Python version was also bumped from 3.7 to 3.8. I'll add that later. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3621 |
…n version add the required dependency async-timeout for Python older than 3.11
@ofborg build python3Packages.asyncpg |
Description of changes
I added the package's dependency on
async-timeout
. Because it was missing, attempting to build it with Python <=3.10 resulted in this error.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.